Footer Width Cropped but Only on Search Results Page

This topic contains 11 replies, has 3 voices, and was last updated by  Paolo 10 years, 5 months ago.

We have moved to a support ticketing system and our forums are now closed.

Open Support Ticket
  • Author
    Posts
  • December 9, 2014 at 7:27 pm #23957

    Fearless_Shultz
    Free User
    Post count: 46

    Hi all,

    Not really sure where best to post this but have a small layout issue in that for some reason on the search results page the footer of my site is showing inside the main content div and thus being cropped width wise.

    It shows fine on the detail page and any other page throughout the site other than the results page. I am using Genesis with the Metro Pro child theme and the footer contains widget areas created with Genesis extender (I have tried using different hooks but can’t seem to find anything that works with the search results page)

    The post below contains some example links and huge thanks in advance for any assistance!

    December 9, 2014 at 7:27 pm #23958

    Fearless_Shultz
    Free User
    Post count: 46
    This reply has been marked as private.
    December 9, 2014 at 10:08 pm #23964

    Guust
    Moderator
    Post count: 29970

    Comments as I am having a look:

    This seems to be a theme problem.
    On the search page, all is contained within the site-container div, but on the other pages the footer parts come after the site-container is closed.
    What I notice too is that on any page where you have the GD search widget, your footer is correct.
    It seems your geodir-genesis-outer div is not closing if you do not have the search in that div.
    Maybe a problem with the custom coding of your advanced search?

    December 9, 2014 at 10:39 pm #23968

    Fearless_Shultz
    Free User
    Post count: 46
    This reply has been marked as private.
    December 9, 2014 at 11:29 pm #23970

    Fearless_Shultz
    Free User
    Post count: 46

    Hi Again Guust,

    After doing some more testing it is obviously an unclosed div somewhere which obviously I will need to find myself as I don’t want to waste anyones time looking for silly mistakes in my code Thanks again for your help! 🙂

    Kind Regards

    Mike

    December 10, 2014 at 9:33 am #23985

    Guust
    Moderator
    Post count: 29970

    That is indeed what I suspect: “It seems your geodir-genesis-outer div is not closing if you do not have the search in that div.”

    Good luck, let us know how you went.

    December 10, 2014 at 1:35 pm #24003

    Fearless_Shultz
    Free User
    Post count: 46

    Adding echo “</div>”; at the end of the geodir-search.php file right before get_footer() seems to have resolved it.

    Thanks again for looking at the problem 🙂

    December 10, 2014 at 1:37 pm #24004

    Guust
    Moderator
    Post count: 29970

    In your customised geodir-search.php or in the standard plugin file?
    Just asking so we can fix if we have to.

    December 10, 2014 at 3:34 pm #24010

    Fearless_Shultz
    Free User
    Post count: 46

    I copied all of the template files over a geodirectory folder within my child theme when I first started customizing. I understood that this is the safest way to work?

    This does bring me to another question actually. I have made some modifications to geodirectory_template_actions.php to change the text that is displayed when a search is completed. At the moment this is still in the plugin folder. Should that file also be moved to avoid issues when updating the plugin?

    December 10, 2014 at 4:14 pm #24014

    Paolo
    Site Admin
    Post count: 31211

    Hi,

    geodirectory_template_actions.php isn’t a template, so it can’t be moved.

    To avoid losing work after updates, customization of these files should be avoided.

    To change text on any page, the translation files should be use.

    Thx

    December 10, 2014 at 5:39 pm #24027

    Fearless_Shultz
    Free User
    Post count: 46
    This reply has been marked as private.
    December 10, 2014 at 5:58 pm #24030

    Paolo
    Site Admin
    Post count: 31211

    Hi again,

    to learn about translations : http://docs.wpgeodirectory.com/category/translation/

    That allows to change all wordings of predifined text strings.

    Not sure this will be enough.

    In any case, if you modify core files, after any update you will lose your changes and you should always avoid that.

    All functions in there can be modified in your functions.php file, because they are all called by actions, so if you remove the original action, than you can copy the function that was being called by the action you removed, rename it, modify it and call it with a new action replacing the original one.

    Hope this will be enough to put you on the right track.

    Thx

  • Author
    Posts
Viewing 12 posts - 1 through 12 (of 12 total)

We have moved to a support ticketing system and our forums are now closed.

Open Support Ticket
20% Discount Offer
Hurry! Get your 20% discount before it expires. Get 20% Discount