Edit Listing version 1.6.20

We have moved to a support ticketing system and our forums are now closed.

Open Support Ticket

Tagged: 1.6.20, listing edit, permalink

Author

Posts
June 1, 2017 at 1:21 pm #381099

Neil Hall
Buyer

Post count: 83

Hi

When I upgraded to version 1.6.20 of Geodirectory I found that I have a problem with editing Listings in the backend.

For example if I edit a Listing called “Windsor Castle” in the PLaces CPT the permalink would normally be …/places/windsor/windsor-castle/. However, with version 1.6.20 installed when I click on ‘edit’ when it opens the listing it adds a ‘-1’ at the end of the permalink so you get …/places/windsor/windsor-castle-1/
This is not good if the permalink changes every time you make a change to a listing
I went back to version 1.6.19 and this does not happen.

Are you aware of this problem? And is there a solution?

Many Thanks for your help

Neil

June 1, 2017 at 3:01 pm #381121

Kor
Moderator

Post count: 16516

Hi Neil,

I’ve just tested on a dev site and I can’t seem to replicate the said issue. Please share WP temp admin access to your site so we can take a better look. You can post the details here using the private reply option below.

June 2, 2017 at 8:07 am #381247

Neil Hall
Buyer

Post count: 83

This reply has been marked as private.

June 2, 2017 at 4:25 pm #381337

Paolo
Site Admin

Post count: 31206

Hi,

I cannot visit your plugin page, it says “Your connection is not secure”, but it looks like you are using a Multi Language plugin that is not compatible.

GeoDirectory is only compatible with WPML.

I believe that’s were the error is coming from.

What happens if you deactivate it?

Let us know,

Thanks

June 2, 2017 at 5:27 pm #381356

Neil Hall
Buyer

Post count: 83

Hi Paolo

I’m not sure why you are getting that message. I have disabled the translation plugin. But the problem is still there. I do not believe it is the translation program as this was working fine with version 1.6.19.

Would you like to try and login again to see if it works.

Best Regards
Neil

June 2, 2017 at 5:33 pm #381357

Paolo
Site Admin

Post count: 31206

Hi,

if it is adding – at the end of your post, it means that something created in the database a duplicate post with the same slug.

Please provide phpmyadmin/cpanel credentials in a private reply and we will verify.

Thanks

June 2, 2017 at 7:03 pm #381375

Neil Hall
Buyer

Post count: 83

This reply has been marked as private.

June 2, 2017 at 7:26 pm #381383

Paolo
Site Admin

Post count: 31206

I flagged this for the developers, they’ll let you know after the week end.

Thanks for your patience,

June 5, 2017 at 11:05 am #381682

Kiran
Moderator

Post count: 7069

Hi Neil,

There was a bug found in previous version, so if same name used for listing title and categories/tags title then it creates same slugs for the listings and categories/tags. This results in problem because it can’t identify whether it is listing or a category/tag if same slug found.

We have added slug validation in recent version, so now same slug can’t be used within listings/categories/tags. If same slug found during save then it appends -1 or -2 etc…

In your case you have already tag “Windsor Castle” with slug “windsor-castle”. That’s why it appended “-1” when you saved listing with title “Windsor Castle”.
To remove -1 fro listing slugs you can edit slug in tags/categories to like “windsor-castle-tag” and then edit listing slug to “windsor-castle”.

Thanks,
Kiran

June 6, 2017 at 8:26 am #381862

Neil Hall
Buyer

Post count: 83

Hi Kiran

Thank you for your explanation, but I don’t understand why you are doing a validation on the Listing name against the category/tag.

From my perception (which may be wrong) the Listing title windsor-castle is actually stored in wp_posts as the ‘post_name’, where windsor-castle as a category/tags are in wp_terms as the ‘slug’. The two are quite separate and can be accessed in different ways.

Can you explain where this becomes a problem as I can’t think of anywhere that this would cause an issue. This has obviously done for some reason and I realize the Geodirectory is very complex with a multitude of functions that I may not be using

Even if the validation is truly needed it does not make any sense to change the permalink of an existing post when it is edited. My feeling is that this should be constant. Could this be fixed?

Alternatively, is there a way that I can turn this validation off?

Best Regards
Neil

June 6, 2017 at 9:24 am #381873

Kiran
Moderator

Post count: 7069

Hi Neil,

Let me explain with example why we have added this. Suppose there is a listing & category with same slug “windsor-castle”.
So now
Category url will be: http://mysite.com/country/region/city/windsor-castle
Detail page url will be: http://mysite.com/country/region/city/windsor-castle

Now with this same url for category & detail page it is impossible for rewrite engine to find whether it is category or a listing detail page.

This is the problem why we have used validation to overcome same slugs for category/tag & listings.

Some of customers have reported this problem, that’s why we applied this fix. You can still modify category/tag/listing slugs from edit page respectively.

Thanks,
Kiran

June 8, 2017 at 8:18 am #382265

Neil Hall
Buyer

Post count: 83

Hi Kiran

Many thanks for your help and the explanation. We have modified the way that we use tags so we do not see this problem anymore.

Best Regards
Neil

June 8, 2017 at 8:56 am #382276

Kiran
Moderator

Post count: 7069

Thanks for letting us know 🙂
Author

Posts