Send button escapes the containing div in the thic-box modal

This topic contains 4 replies, has 3 voices, and was last updated by  Vikas 10 years, 5 months ago.

We have moved to a support ticketing system and our forums are now closed.

Open Support Ticket

Tagged: ,

  • Author
    Posts
  • #6664

    Jason Kadlec
    Free User
    Post count: 22

    Pretty sure it’s not just my theme:

    http://cl.ly/image/3f1Z0g2Z2z1L

    This the modal that launches when you click on “Send Enquiry” or “Send to Friend” in the listing details sidebar.

    When the modal opens all the content inside is in the right place -but the javascript has now hard set the height of the content div.

    When the error messages show up below the field – they add a little height to the inner div, which pushes the “send” button down below the container as shown in the screen shot.

    I tried overriding the default in the thic-box css by setting:

    #basic-modal-content {height: 700px;}

    in my over-ride css — as the “send to a friend” was already broken looking on launch.

    So this pretty much works now – as long as the errors don’t show and push the send button down.

    But you may want to look at Easy Fancy Box — whatever library they’re using has a really nice and playful animation when you open/close the modal.

    I think the Easy Fancy Box also aligns more center of the screen which is nice for those of us using fixed headers – I had to override the modal’s Top positioning as the top of the box was under my header.

    One last thing about the thic-box modal — it doesn’t close when clicking on the background — the user has to click the X which I though odd as almost all modals I’ve seen out there all close when you click outside the content.

    #6824

    Paolo
    Site Admin
    Post count: 31206

    Hi,

    pretty sure it’s the theme:

    http://wpgeo.directory/hotels/united-states/new-york/new-york/5-stars/crosby-street-hotel/

    If you provide a link I can confirm or not, anyway this should fix it:

    
    
    
    .simplemodal-data {
        overflow: hidden;
    }
    
    
    #6896

    Jason Kadlec
    Free User
    Post count: 22

    @paolo – that just ends up hiding the send button — have a look:

    http://dev.theinvisionlab.com/community/?gd_place=michele-domingo

    On the page you linked to – the same behavior applies you’ll see the send button scoot down as the error warnings get added.

    To some extent – is is my theme -which it looks like has increased the font size and form input fields such that now the containing box is too small… but overall this will continue to break on other themes that also have larger fonts/input boxes.

    I can shrink down my font in the box / make the box bigger for now — but I think you’ll have better compatibility with themes if you use a different modal plugin – one that:

    1) doesn’t hard set the height such that the height can’t adjust to additional content inside the modal.

    2) Allows the user to click outside the modal (eg on the translucent bg) to close the modal box if they don’t click the (x).

    Once again, I really like the Easy Fancy Box stylins — check it in action here — click the “Sign Me Up” button http://colettebaronreid.com

    Try adding lines to it via inspect element — and you’ll see that the modal box has no trouble increasing its height.

    #6996

    Paolo
    Site Admin
    Post count: 31206

    Ok,

    sorry about that, I misunderstood the problem at first.

    This css should fix the height problem of the modal box.

    
    
    
    #basic-modal-content2 {
        height: auto;
    }
    
    

    As far as closing the window by clicking on the overlay I have to flag it for Vikas.

    Thx

    #7181

    Vikas
    Full Member
    Post count: 1128

    Hi Jason,
    I have fixed the 2nd issue mentioned about Close modal when click outside. It will be there in next release.
    If u want to check plz download attached zip and extract. Upload post.custom.js in it to Your (Core)geodirectory geodirectory-assets > js >

Viewing 5 posts - 1 through 5 (of 5 total)

We have moved to a support ticketing system and our forums are now closed.

Open Support Ticket
20% Discount Offer
Hurry! Get your 20% discount before it expires. Get 20% Discount