Sign in & Sign up forms have same input id value

This topic contains 7 replies, has 2 voices, and was last updated by  Paolo 9 years ago.

We have moved to a support ticketing system and our forums are now closed.

Open Support Ticket
  • Author
    Posts
  • September 14, 2015 at 8:00 pm #53162

    Y A
    Expired Member
    Post count: 156

    Hi,
    Very minor…

    Both the sign in and sign up form both have input fields with the id “user_pass”. This is a problem considering that both forms show up on the same ?geodir_signup=true page; and this prevents proper targeting of each password field.

    September 15, 2015 at 1:58 am #53195

    Paolo
    Site Admin
    Post count: 31206

    Hi,

    not true, both elements have their own unique parent element.

    Login password input field:

    #cus_loginform #user_pass {/*css here*/}

    Register password input field:

    #cus_registerform #user_pass {/*css here*/}

    It could be a problem for w3c validation though. So I’ll flag this for developers.

    Thanks

    September 15, 2015 at 2:03 am #53196

    Y A
    Expired Member
    Post count: 156

    Although they can indeed be accessed through CSS, jQuery and javascript fail to identify it by ID.

    September 15, 2015 at 2:14 am #53201

    Paolo
    Site Admin
    Post count: 31206

    Task for the developers is open, I’m sure this will be solved very quicky. 🙂

    Thanks

    September 15, 2015 at 3:00 pm #53264

    Paolo
    Site Admin
    Post count: 31206

    Hi,

    this has been fixed and will be in next version. It is a 1 tiny change so if you want to start applying it, you find it here: https://github.com/GeoDirectory/geodirectory/commit/0d98367c7dd7f0768ad54829db6421a9155ab5e8

    line 88 of geodirectory-templates/reg_frm.php

    Thanks

    September 15, 2015 at 7:10 pm #53296

    Y A
    Expired Member
    Post count: 156

    Great, thanks!

    September 15, 2015 at 8:13 pm #53298

    Y A
    Expired Member
    Post count: 156

    By the way, might as well do something about the multiple <span id=”user_fnameInfo”> below user_pass and user_pass2

    September 17, 2015 at 2:59 pm #53433

    Paolo
    Site Admin
    Post count: 31206

    Hi,

    we fixed that too.

    Thanks for the heads up!

  • Author
    Posts
Viewing 8 posts - 1 through 8 (of 8 total)

We have moved to a support ticketing system and our forums are now closed.

Open Support Ticket
20% Discount Offer
Hurry! Get your 20% discount before it expires. Get 20% Discount