Marc Mathys
Forum Replies Created
-
Posts
-
This reply has been marked as private.
Hi Paolo,
Thanks, so if it’s not something you guys would add, I’m going to code it myself. I have it almost working. I created a new short code that mimics [gd_popular_post_category] but has another argument. I added all_cpt=true to it, passed it to a new function which mimics geodir_popular_post_category_output()
In my new function, I added
$all_cpt = !empty( $instance['all_cpt'] ) ? true : false;to get the argument in.
For testing purposes, I changed the equivalent of line 2834 of /geodirectory-functions/general-functions.php from
if ( count( $b_terms ) > 1 ) {to
if ( count( $b_terms ) > 1 || $all_cpt ) {And it works so far, except that the select dropdown still only shows “places” as an option when I’m on a listing’s page and it’s missing the other CPT types. Instead, I understand that I need to populate $b_terms with the list of CPT, and this the couple of lines of code that I need help with. I’d appreciate your support with this.
Thanks,
MarcHi Stiofan,
Great, how about 14:00 or 15:00 CET ?
Talk to you tomorrow.Best,
MarcHi Stiofan,
Happy New Year!! Would tomorrow or Thursday work for a skype session?
Let me know. Thanks,
MarcHi Stiofan,
Thanks for tuning that, it’s a good start… but there are still some issues:
1. On the bottom of the homepage, there are 3 pictures that should be in a slider instead of appearing on top of each other (kleo theme functionality).
2. On the home page, the background of the menu doesn’t stay dark when scrolling down (only when hover). I have those settings in my theme’s CSS section. Interesting, I have the same settings on the events page but it works there.
3. On single events pages, the LinkedIn share logo is replaced with this “–>” (it should be right below the facebook share button)
4. The masonry displaying blog articles is completely gone, this is a visual composer functionality that came with kleo theme (click blog from the menu)
5. A bunch things don’t work anymore on the Service page:
– Testimonial module disappeared (kleo theme functionality)
– Client logo shade settings and animation don’t work (kleo theme functionality)
– Most images are missing
– Screenshot images with dots over them to point to features are gone (kleo theme functionality)
– Icons in feature list don’t animate (kleo them functionality)
– “Go Pricing” (plugin) tables are gone6. On the About us page, the team images are missing
7. Even with GD there are some problems:
– Directory home page displays a map with 3 times the world and no pins
– Single listing map doesn’t loadI turned it back off for now.
Best,
MarcThis reply has been marked as private.Hi Stiofan,
Brilliant, I added this line to remove the description as well. My SEO plugin (SEO Framework) already provides description and keywords.
add_filter('geodir_seo_meta_description','__return_empty_string');Thanks,
MarcThis reply has been marked as private.Hi Stiofan,
Sorry for the delay. We can talk about #1 and #2 after Christmas if you’re around. I’ll send my skype ID in a private message.
I partially solved #3 with WPML, there is an option to replicate the comments to duplicates (works only for new comments, but oh well). However, there are 2 things that still don’t work properly with GD:
#3a: The number of comments shown is wrong in the title. It will say “0 Comments” and show 1 or 2 comments from the duplicate entries.
#3b: The star rating doesn’t make it across to the duplicate.
Your short answer about #4 has the risk of rendering the entire multilingual GD setup unusable. Both manually editing in 3 languages in the back-end or tracking every front-end change to manually replicate it in the 2 other languages are unthinkable from an operations perspective. I don’t need a perfect setup, just something workable, something like this would be perfect:
* Prevent front-end changes to a duplicate, instead redirect to the original language listing edit on the front-end
* Run a script every night to check on edit date of an original and if it has been updated, overwrite the duplicates’ content with the original’s (+ total and sync star ratings).Merry Christmas,
MarcHi Stiofan,
I ran into another issue today, related to WPML listings. Let’s call it #4 :
When a listing has WPML “duplicates” in other language, changing the name of the store, the contact email address, the phone number, the website, the address, the descriptions, or the photos of a listing on the original does not copy over to the duplicates. My understanding of a WPML “duplicate” is that it allows to not have to maintain the exact same information twice, otherwise it’s a “translation”.
How can these fields be linked together ? Does that require a script to run every night and copy the fields of recent updates to their “duplicate” records ?
The practical question behind it, is that I can’t expect a store owner in the French speaking area to manage his store information on the French, English and German version of the site. Most likely, he doesn’t even understand German or English.
Best,
MarcHi Stiofan,
Thanks, the displaying works well… if no edits are made. The slug is always switzerland while the country in the address and in the breadcrumb gets localized correctly.
While that’s a good step forward, it’s doesn’t hold in a world where entries get modified. Editing will mess everything up again… here are the 2 simple steps I took:
1. Editing post ID 11771 from the French language front end (like the owner would do). This changed the language in the post_country for both 11771 and 11983 (its English duplicate) to “Suisse”.
2. Then as an admin, I tried editing post ID 11771 from the back end (with WordPress being in English), the post did not have a country selected (Suisse is not in the list of English countries). I had to select Switzerland again, which removed the region and city, so I had to add them again before being able to save. This switched post_country back to “Switzerland” for ID 11771, but the duplicate still has post_country set to “Suisse” from step 1 – and this is visible on the English site (see the country here: https://www.arbolife.com/listing/switzerland/neuchatel/boudevilliers/brocante-bric-a-brac/)
I left it at this stage in the db for you to look at.
I hope you would agree, that this isn’t exactly a durable setup. I think when a user edits from the French front end (step 1 above), it should save the country in English in the database, even if the front end country selector shows the country in French.
(Just in case, since your last login, I imported 70 listings in German and 5 in French and duplicated the content to English).
—
And when we’re done with this, there is still point number 3 from my first post. Just so it’s clear, I’m in no rush to get this perfect. I’m blown away by the top quality of your support, so I want to make sure it doesn’t come across as pressure, so just a reminder.
3. Comments and ratings don’t appear on the duplicated version. Imagine a multi-lingual country, If I want to go to a place outside my language area, I’d like to see the ratings without having to switch the language of the website to the language of that area to see what the locals have to say about the place.
Best,
MarcThis reply has been marked as private.Hi Stiofan,
Thank you for your excellent support. Let’s wait a few days and see where this goes. Until then I’ll delete all the spam registration to my site manually.
Let me know.
Best,
MarcHi Stiofan,
I heard back from Steven from WP-SpamShield and he suggests that they help you make changes to “4 lines of code of less” in GeoDirectory to make the registration function properly with WP-SpamShield.
I sense this conversation could be heading towards who’s right and who’s wrong regarding following WordPress standards. As the proxy in this conversation, I request this argument be either kept off this channel or taken offline between the two of you. My goal is to help build a bridge and it appears both you and Steven have the right intentions to see this compatibility issue resolved.
I’d like to encourage you to contact Steven via this form as he suggested: https://www.redsandmarketing.com/plugins/wp-spamshield/hooks/
Thank you,
MarcHi Marc,
One of the unfortunate oddities in the world of WordPress plugins, is that paid plugins tend to be worse at following WordPress standards. You would expect it to be the other way around, but it’s something we’ve found over and over.
Regarding compatibility fixes…The general rule of thumb is that the plugin with fewer users makes the compatibility fixes. Our code follows WordPress coding standards very strictly, which is why it’s compatible with almost every plugin out there. The list of plugins it’s not compatible with is very short, considering that it supports everything. Being that the actual error is with the GeoDirectory code (as I mentioned previously), and they have far fewer plugin users — their 10,000 active users vs. our almost 200,000 active users (& over 2 million downloads) — they really should be the one making changes. (There are a number of reasons for this – it’s partly etiquette, partly to keep the code of a user’s site lean, and partly to prevent introducing new conflicts.)
We have developed code hooks that other developers can use and we’ll be happy to help them if they contact us via the link I gave you. It will literally take them 4 lines of code or less. We generally only add compatibility fixes for plugins that are among the 100-200 most used WordPress plugins, and that’s at our discretion. Most plugin developers are happy to work with us and vice versa.
Hacking the code is not advisable, and we don’t provide support for sites that used hacked versions of the plugin.
I read the post, and the part where he says the following is blatantly false:
to say it does not follow WP standards is untrue
Unfortunately he either doesn’t want to admit it, or doesn’t understand how it is not compliant. We can show exactly how it is not following WordPress standards.Hi Stiofan,
Thanks a lot for doing the research and suggesting what appears to be a relatively simple fix.
I sent your message to Steven from WP-SpamShield. I’ll keep you posted here.Best,
Marc
