Rainer Lang

Forum Replies Created

Viewing 13 posts - 16 through 28 (of 28 total)
  • Author
    Posts
  • in reply to: Security issues – more sanitizing please #260834

    Rainer Lang
    Expired Member
    Post count: 33

    Hi Stiofan,
    we really appreciate your security consciousness and hope to go best with GeoDirectory.
    No, we don’t use a scanner, just own eyes on the monitor of our WordPress security experienced developer.
    We’re looking forward to read your review. Do you have any results yet?

    in reply to: potential bugs found in code #260831

    Rainer Lang
    Expired Member
    Post count: 33

    I don’t really understand your intention to use the localize function. Why don’t use

    esc_url(get_option('siteurl')) . '?geodir_ajax=true'

    ?

    in reply to: php notices (in debug mode) #260827

    Rainer Lang
    Expired Member
    Post count: 33
    This reply has been marked as private.
    in reply to: php notices (in debug mode) #260815

    Rainer Lang
    Expired Member
    Post count: 33
    This reply has been marked as private.
    in reply to: potential bugs found in code #260258

    Rainer Lang
    Expired Member
    Post count: 33

    Hi Stiofan,
    any news on this?

    in reply to: php notices (in debug mode) #260255

    Rainer Lang
    Expired Member
    Post count: 33

    Hello Stiofan,
    we updated to WP 4.6 and GeoDirectory 1.6.6 – the notices still appear.
    Have you checked that yet?

    /geodirectory-admin/admin_functions.php line 2022 throws an error in backend edit modus of an entry (place/event).
    /geodirectory-functions/custom_fields_functions.php now line 1384 appears in listed entry on the homepage.
    readonly is still wrong in line 2470

    We didn’t check the whole site again yet.
    Please don’t ignore these issues and please tell us about your engagements on this.

    in reply to: php notices (in debug mode) #233717

    Rainer Lang
    Expired Member
    Post count: 33

    Hello Stiofan,
    thanks for your reply.
    No, we don’t use a scanner, we checked it manually.
    This reported notices above were appearing on our site, exactly with these line numbers. So we set the conditions in the code, and the notices were gone. So there definitely must be a way that the value is not set, as it is in our case.
    Maybe the value has not been set, because we migrated the data from GeoPlaces by database and your import function. I guess the values are set correctly when using the admin interface, but by using the import function it seems to lack some values.

    in reply to: potential bugs found in code #233703

    Rainer Lang
    Expired Member
    Post count: 33
    This reply has been marked as private.
    in reply to: Security issues – more sanitizing please #233698

    Rainer Lang
    Expired Member
    Post count: 33
    This reply has been marked as private.
    in reply to: Security issues – more sanitizing please #233697

    Rainer Lang
    Expired Member
    Post count: 33
    This reply has been marked as private.
    in reply to: Security issues – more sanitizing please #233695

    Rainer Lang
    Expired Member
    Post count: 33
    This reply has been marked as private.
    in reply to: Security issues – more sanitizing please #233694

    Rainer Lang
    Expired Member
    Post count: 33
    This reply has been marked as private.
    in reply to: Parent Categories #233691

    Rainer Lang
    Expired Member
    Post count: 33

    Hello,
    in our setup we use category hierarchy for a better structure, too, most entries are not linked to a parent category, but to subcategory only. On the map’s category list we need the total count for parent categories, including subcategories. So we changed the function geodir_filter_empty_terms() in geodirectory-functions/general_functions.php lines 4786-4798. Maybe you are interested in this code, too.

    Dear developers, we would be very glad if you implement this code into the next version. Otherwise could you please add a hook that we can modify it without hacking the code?

    
    
    
    function geodir_filter_empty_terms($terms) {
        if (empty($terms)) {
            return $terms;
        }
    
        $return = array();
        foreach ($terms as $term) {
            if (isset($term->count) && $term->count > 0) {
                $return[] = $term;
            } 
    	else if(!empty($term)) {
    		$count = 0;
    		$taxonomy = $term->taxonomy;
    		$args = array(
    			'child_of' => $term->term_id,
    		);
    		$tax_terms = get_terms($taxonomy,$args);
    		foreach ($tax_terms as $tax_term) {
    				if( $tax_term->count > 0) {
    					$return[] = $term;
    					break;
    				}
    		}
    
    	}
        }
        return $return;
    }
    
    

    Suggestion for a filter hook:

    
    
    ...
    	else if(!empty($term)) {
    		$return = apply_filters( 'geodir_filter_empty_terms_filter', $term);
    
    	}
    
Viewing 13 posts - 16 through 28 (of 28 total)