php notices (in debug mode)

This topic contains 7 replies, has 2 voices, and was last updated by  Stiofan O’Connor 7 years, 8 months ago.

We have moved to a support ticketing system and our forums are now closed.

Open Support Ticket

Tagged: 

  • Author
    Posts
  • #233685

    Rainer Lang
    Expired Member
    Post count: 33

    Dear plugin developers,
    in our testing environment a couple of php errors and notices were coming up (debug on, php 5.6), most related to undefined variables. Could you please add some conditional values like this:

    $post_package_id = !empty($package_info->pid) ? $package_info->pid : '';

    in geodirectory_hooks_actions.php line 2426,

    geodirectory_template_actions.php line 2326, and in line 2375:

    $image_limit = isset($package_info->image_limit) ? $package_info->image_limit : -1;

    /geodirectory-admin/admin_functions.php line 2022, and inside input tag

    readonly

    instead of

    readonly="readonly"

    , line 2668, 2788

    /geodirectory-functions/custom_fields_functions.php 2184, readonly in line 1880 and 4035, additional:

    if (isset($post->{$type['htmlvar_name']})):

    in line 2388 and 2885 and and of line 2828

    and in geodirectory_payment_functions.php (AddOn Payments Manager) line 3182

    –GeoDirectory 1.6.4, WP 4.5.3, PHP 5.6–

    #233713

    Stiofan O’Connor
    Site Admin
    Post count: 22956

    Hi Rainer,

    It appears like you are running GD through some sort of scanner, most of what you have reported so far has been false positives, for example geodirectory_template_actions.php line 2326, there is no way for this value to not be set, if you trace it back through the function calls. I appreciate your efforts but please double check anything manually before reporting it.

    Thanks,

    Stiofan

    #233717

    Rainer Lang
    Expired Member
    Post count: 33

    Hello Stiofan,
    thanks for your reply.
    No, we don’t use a scanner, we checked it manually.
    This reported notices above were appearing on our site, exactly with these line numbers. So we set the conditions in the code, and the notices were gone. So there definitely must be a way that the value is not set, as it is in our case.
    Maybe the value has not been set, because we migrated the data from GeoPlaces by database and your import function. I guess the values are set correctly when using the admin interface, but by using the import function it seems to lack some values.

    #260255

    Rainer Lang
    Expired Member
    Post count: 33

    Hello Stiofan,
    we updated to WP 4.6 and GeoDirectory 1.6.6 – the notices still appear.
    Have you checked that yet?

    /geodirectory-admin/admin_functions.php line 2022 throws an error in backend edit modus of an entry (place/event).
    /geodirectory-functions/custom_fields_functions.php now line 1384 appears in listed entry on the homepage.
    readonly is still wrong in line 2470

    We didn’t check the whole site again yet.
    Please don’t ignore these issues and please tell us about your engagements on this.

    #260312

    Stiofan O’Connor
    Site Admin
    Post count: 22956

    Hi Rainer,

    I don’t see any errors at my end, please provide the exact output from the error log.
    “readonly is still wrong in line 2470” its a hidden field…

    Stiofan

    #260815

    Rainer Lang
    Expired Member
    Post count: 33
    This reply has been marked as private.
    #260827

    Rainer Lang
    Expired Member
    Post count: 33
    This reply has been marked as private.
    #260829

    Stiofan O’Connor
    Site Admin
    Post count: 22956

    I have made some changes but really, its only caused if you deliberately disable all the price packages and then try to add a package..

    Thanks,

    Stiofan

Viewing 8 posts - 1 through 8 (of 8 total)

We have moved to a support ticketing system and our forums are now closed.

Open Support Ticket