Bruce Frantzis

Thanks for the quick confirmation Alex. Good to know its not just our site.

At this point I have everything working as I want it. I am not asking Geodirectory to change anything. I am simply trying to correct misinformation.

Just to clear things up, we have always required an exact location, GPS to street.

That is not true and has been stated many times by different GeoDirectory staff. Has anyone actually tested entering “Brighton, UK”? Both v1 and v2 allow entering an address like this that does not include the street. Do I have to make a video to show this before you will believe me? This is very simple to test.

If it’s not showing that then its a bug

I don’t know what you mean by “not showing” in this context. The address shows up on map when Street is omitted. The admin and user UI both work when Street is omitted. The only problem I had was with the City name being shown twice in the printed address when Street is omitted. In this case the Street should not be showing. I have fixed this with my code (in post above).

We do have a feature that will fill the street with the best know info if somehow it is empty.

This ‘feature’ does not work correctly as it is using the City value “Brighton” as the Street value when Street value is not entered. A more useful feature would be to allow admin to set Street as optional (as was previously allowed) and keep the Street value empty.

At this point in time, we simply do not provide that functionality, an exact location is currently required (including street).

You are so close to having this feature. All you need is the admin setting to make street optional as mentioned above.

If you know of a directory currently mixes exact locations with non-exact locations please let us know.

Our directory does this. Right now, as is, this is working sufficiently well. When Street is omitted the GPS coordinates are set to city center. The pin appears on maps and locations appear in search results when proximity searched. This does result in many pins appearing in same location but Google Maps handles this well enough.

Many sites use imprecise GPS coordinates to protect end users. Craigslist.org uses this in “For Sale” listings. e.g. If you are selling a car then you want customer to know roughly where it is but do not want them to know exact street address as malicious people may try to steal it. It looks like Craigslist just moves the exact position by a random distance (within a range e.g. 1000-3000 ft) in a random direction. They then change the map marker to a circular range rather than a point.

I have to say that I am disheartened by the level of support on this issue. Clearly anyone can enter an address without specifying a street. Clearly Street is not a required field in the database. There really is no reason why this should be mandatory. This is a problem introduced in code that limits functionality unnecessarily.

I am also disappointed that no good solution was provided to fix this. In the end I had to debug the code and implement a fix. To save others the hassle of contacting support I provide it below:

Add this to theme functions.php file:

// Hide duplicate City text intriduced by bug in geodirectory.
add_filter( 'geodir_custom_field_output_address_fields' , 'duplicate_city_address_filter');
function duplicate_city_address_filter($address_fields) {
  if (!empty($address_fields['street']) && !empty($address_fields['city'])) {
    $street_raw = strip_tags($address_fields['street']);
    $city_raw = strip_tags($address_fields['city']);
    if ($street_raw == $city_raw) {
      unset($address_fields['street']);
    }
  }
  return $address_fields;
}

This code checks the saved values of ‘Street’ and ‘City’. If they are the same, which happens when ‘Street’ was not entered, then the ‘Street’ value is removed and will not be displayed. This does not alter any saved data and is applied whilst the page is being rendered.

Found the setting in GeoDirectory v1. Note last form input in screenshot shows you can make it optional.

address fields are mandatory, including the street address field

– There is a setting in Geodirectory v1 to make Street optional. Cannot find this in v2.
– Geodirectory v1 and v2 allow entry without street as in the example provided above.
-The Street field in database allows empty values.

This was working for us in v1 and we are having problems with it whilst testing v2. Are you saying that this has changed?

the value retrieved from the API is left in place. It is not a bug.

Are you saying that it’s normal practice to copy the city into the street, if street is empty, rather than displaying address without street? That certainly does not sound like normal practice and does sound like a bug to me.

Are you using OSM?

Probably not as I do not know what it is. Please can you provide more info?

Either way, bug or not, how can I fix this in code when the underlying stored data is wrong? It needs to be fixed in a way that hides City from Street field, does not make address entry more difficult, and retains functionality for people who:

– Do not enter street
– Enter 1 street line
– Enter 2 street lines

Please provide code samples of how to fix it.
Thanks

EDIT – previous reply did not display unordered lists. Tried to fix and the post disapperead. Posting again using simple dashes for lists.

Ok we have determined that was an issue with the permalinks within GD. Reset them and they are working now. Thanks.

Hi Alex, I believe we have that implemented. For example, now if you start to type in “Wu Style” in the search bar, the categories with that name come up as suggestions below the search bar. Please see the screenshot attached.

Hi Alex,

Here is the page with the Instructors.

https://www.energyarts.com/instructors-search/

And the search bar is right below “Find an Energy Arts Instructor”

Thanks.