Version 1.3.2 – Details Tab Fix

This topic contains 5 replies, has 3 voices, and was last updated by  Paolo 9 years, 4 months ago.

We have moved to a support ticketing system and our forums are now closed.

Open Support Ticket
  • Author
    Posts
  • January 2, 2015 at 1:50 pm #26063

    adriangraham
    Expired Member
    Post count: 426

    Guys,

    I don’t want to do a full upgrade to 1.3.2 just yet as I have just completed a full upgrade…. but what would i need to change in order to have this fix on my website…the following taken from release notes:

    “Details page tab content is now showen before JS has finished loading – CHANGED”

    Adrian

    January 2, 2015 at 2:01 pm #26066

    Stiofan O’Connor
    Site Admin
    Post count: 22956

    i don’t remember the exact changes but it’s a js and a functions change, why not upgrade, get me on skype if u want help.

    Thanks,

    Stiofan

    January 2, 2015 at 2:10 pm #26067

    adriangraham
    Expired Member
    Post count: 426
    This reply has been marked as private.
    January 2, 2015 at 8:05 pm #26135

    Paolo
    Site Admin
    Post count: 31206

    Hi Adrian,

    translations are not lost with updates if done correctly.

    Have you changed core files? (you shouldn’t!)

    We can’t provide the type of support you are asking here in any case. We don’t log the exact change we do in the code base. We would have to compare files of the old version with files of the new version with winmerge and that very time consuming.

    That’s why you shouldn’t change core files under any circumstances.

    Thanks

    January 3, 2015 at 10:37 am #26181

    adriangraham
    Expired Member
    Post count: 426

    Hey Paolo,

    Translations are overwritten with an upgrade I thought…. I know you can just replace the MO file back in again (assuming no new translations have been added).

    When you say core file, what do you mean? I thought all modifications that people do are to core files? Examples of files I have changed along the way are:

    geodir_payment_functions.php
    listing-listview.php
    geodir_avada_compatibility.php
    geodir-signup.php
    general_functions.php

    etc

    Are these considered core?

    Thanks!

    Adrian

    January 3, 2015 at 4:29 pm #26217

    Paolo
    Site Admin
    Post count: 31206

    If you do it the right way, no they are not overwritten upon update:

    http://docs.wpgeodirectory.com/translate-core/
    http://docs.wpgeodirectory.com/translating-addons/

    geodir_payment_functions.php
    listing-listview.php
    geodir-signup.php
    general_functions.php

    Are core files and should never be edited unless you don’t care to keep your plugin updated with new releases.

    geodir-signup.php and listing-listview are templates and can be modified by moving them inside a folder named geodirectory inside your active theme for example.

    For functions, depending what you want to do, in most cases you can alter the plugin behaviour with hooks and actions, writing functions within your theme, leaving the plugin files unaltered.

    Thanks

  • Author
    Posts
Viewing 6 posts - 1 through 6 (of 6 total)

We have moved to a support ticketing system and our forums are now closed.

Open Support Ticket